xfs
[Top] [All Lists]

Re: [PATCH 1/1] XFS: Deletion of unnecessary checks before two function

To: SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 1/1] XFS: Deletion of unnecessary checks before two function calls
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 1 Dec 2014 10:09:04 +1100
Cc: xfs@xxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, Julia Lawall <julia.lawall@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5479F823.60900@xxxxxxxxxxxxxxxxxxxxx>
References: <530C5E18.1020800@xxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.10.1402251014170.2080@hadrien> <530CD2C4.4050903@xxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.10.1402251840450.7035@hadrien> <530CF8FF.8080600@xxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.02.1402252117150.2047@xxxxxxxxxxxxxxxxxxxxxxx> <530DD06F.4090703@xxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.02.1402262129250.2221@xxxxxxxxxxxxxxxxxxxxxxx> <5317A59D.4@xxxxxxxxxxxxxxxxxxxxx> <5479F823.60900@xxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Nov 29, 2014 at 05:45:23PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sat, 29 Nov 2014 17:40:22 +0100
> 
> The functions xfs_blkdev_put() and xfs_qm_dqrele() test whether their argument
> is NULL and then return immediately.
> Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

Looks fine.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>


-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>