xfs
[Top] [All Lists]

Re: [PATCH 3/4] vfs: don't let the dirty time inodes get more than a day

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/4] vfs: don't let the dirty time inodes get more than a day stale
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Wed, 26 Nov 2014 05:20:17 -0500
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=jDRmmrCvZ/czo8kDav6OMpk5TJXaEzivdmpqOTLzmWc=; b=f6KgXFYp6qBhHRigmWUHJI8wXUm1AWBnvErPFZXRDkIPBAyVVml5CjjppRSXHTXtwn45Tz4M4GJ61+sIsNMTCIKKd0CHx8ncByZ0ODA4oMkNoNubjqwMxW1TIh773xrrXjhH2+bGP/NczyrRsnakOIDn90Js+7B+8/0xWggQU1k=;
In-reply-to: <20141125234851.GB9561@dastard>
References: <1416599964-21892-1-git-send-email-tytso@xxxxxxx> <1416599964-21892-4-git-send-email-tytso@xxxxxxx> <20141125015332.GE27262@dastard> <20141125044508.GG31339@xxxxxxxxx> <20141125234851.GB9561@dastard>
User-agent: Mutt/1.5.23 (2014-03-12)
On Wed, Nov 26, 2014 at 10:48:51AM +1100, Dave Chinner wrote:
> No abuse necessary at all. Just a different inode_dirtied_after()
> check is requires if the inode is on the time dirty list in
> move_expired_inodes().

I'm still not sure what you have in mind here.  When would this be
checked?  It sounds like you want to set a timeout such that when an
inode which had its timestamps updated lazily 24 hours earlier, the
inode would get written out.  Yes?  But that implies something is
going to have to scan the list of inodes on the dirty time list
periodically.  When are you proposing that this take place?

The various approaches that come to mind all seem more complex than
what I have in this patch 3 of 4, and I'm not sure it's worth the
complexity.

                                                - Ted

<Prev in Thread] Current Thread [Next in Thread>