xfs
[Top] [All Lists]

Re: [PATCH-v3 6/6] btrfs: add an is_readonly() so btrfs can use common c

To: Theodore Ts'o <tytso@xxxxxxx>
Subject: Re: [PATCH-v3 6/6] btrfs: add an is_readonly() so btrfs can use common code for update_time()
From: David Sterba <dsterba@xxxxxxx>
Date: Tue, 25 Nov 2014 17:02:56 +0100
Cc: Linux Filesystem Development List <linux-fsdevel@xxxxxxxxxxxxxxx>, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, Linux btrfs Developers List <linux-btrfs@xxxxxxxxxxxxxxx>, XFS Developers <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1416893674-419-7-git-send-email-tytso@xxxxxxx>
Mail-followup-to: dsterba@xxxxxxx, Theodore Ts'o <tytso@xxxxxxx>, Linux Filesystem Development List <linux-fsdevel@xxxxxxxxxxxxxxx>, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, Linux btrfs Developers List <linux-btrfs@xxxxxxxxxxxxxxx>, XFS Developers <xfs@xxxxxxxxxxx>
References: <1416893674-419-1-git-send-email-tytso@xxxxxxx> <1416893674-419-7-git-send-email-tytso@xxxxxxx>
Reply-to: dsterba@xxxxxxx
User-agent: Mutt/1.5.23.1-rc1 (2014-03-12)
On Tue, Nov 25, 2014 at 12:34:34AM -0500, Theodore Ts'o wrote:
> The only reason btrfs cloned code from the VFS layer was so it could
> add a check to see if a subvolume is read-ony.  Instead of doing that,
> let's add a new inode operation which allows a file system to return
> an error if the inode is read-only, and use that in update_time().
> There may be other places where the VFS layer may want to know that
> btrfs would want to treat an inode is read-only.
> 
> With this commit, there are no remaining users of update_time() in the
> inode operations structure, so we can remove it and simply things
> further.
> 
> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
> Cc: linux-btrfs@xxxxxxxxxxxxxxx

Reviewed-by: David Sterba <dsterba@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>