xfs
[Top] [All Lists]

Re: [PATCH 1/4] fs: split update_time() into update_time() and write_tim

To: dsterba@xxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Theodore Ts'o <tytso@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 1/4] fs: split update_time() into update_time() and write_time()
From: David Sterba <dsterba@xxxxxxx>
Date: Tue, 25 Nov 2014 16:51:41 +0100
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20141124173430.GB26471@xxxxxxxxxxxxx>
Mail-followup-to: dsterba@xxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Theodore Ts'o <tytso@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
References: <1416599964-21892-1-git-send-email-tytso@xxxxxxx> <1416599964-21892-2-git-send-email-tytso@xxxxxxx> <20141124152101.GA12575@xxxxxxxxxxxxx> <20141124173430.GB26471@xxxxxxxxxxxxx>
Reply-to: dsterba@xxxxxxx
User-agent: Mutt/1.5.23.1-rc1 (2014-03-12)
On Mon, Nov 24, 2014 at 06:34:30PM +0100, David Sterba wrote:
> The btrfs_root_readonly checks in setxattr and removexattr are
> unnecessary because they're done through xattr_permisssion. I'll send a
> patch to remove them.

Does not work because the security.* and system.* namespaces do not call
the permission() hook, so no patch. However, if the proposed
inode_is_readonly callback is merged, we can replace the btrfs-specific
checks with is_readonly check in xattr_permission().

<Prev in Thread] Current Thread [Next in Thread>