[Top] [All Lists]

Re: [PATCH-v2 0/5] add support for a lazytime mount option

To: "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
Subject: Re: [PATCH-v2 0/5] add support for a lazytime mount option
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Mon, 24 Nov 2014 19:32:15 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=BtpuIarwk3h/dNMnb7OnOCpJ+XgJDP0gqjn2ka36GeU=; b=ZjZJ6YPoZPVp4S1vvx6jMUXxzLtmeKhLtTvnDTR7/ovWEFm2//7BqIgLhZOfOZ/Df6El/UtN0NJ2tjrEQBUhEEYg5SPIiuzdy4pphcZG3VPZwUXH/6gRT2VUzkXN4FGwGJg0Lm8Xr3SA9Oi8pNAgSMbqELqzby/xHyHuCC1M844=;
In-reply-to: <20141124221145.GB24003@xxxxxxxxxxxx>
References: <1416675267-2191-1-git-send-email-tytso@xxxxxxx> <20141124090755.GA28534@xxxxxxxxxxxxx> <20141124115727.GA19918@xxxxxxxxx> <20141124221145.GB24003@xxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Mon, Nov 24, 2014 at 05:11:45PM -0500, J. Bruce Fields wrote:
> On Mon, Nov 24, 2014 at 06:57:27AM -0500, Theodore Ts'o wrote:
> > If we want to be paranoid, we handle i_version updates non-lazily; I
> > can see arguments in favor of that.
> > 
> > Ext4 only enables MS_I_VERSION if the user asks for it explicitly, so
> > it wouldn't cause me any problems.  However, xfs and btrfs enables it
> > by default, so that means xfs and btrfs wouldn't see the benefits of
> > lazytime (if you're going to have to push I_VERSION to disk, you might
> > as well update the [acm]time while you're at it).  I've always thought
> > that we *should* do is to only enable it if nfsv4 is serving the file
> > system, and not otherwise, though, which would also give us
> > consistency across all the file systems.
> I guess you need to worry about the case where you shutdown nfsd, modify
> a file, then restart nfsd--you don't want a client to miss the
> modification in that case.

Hmmm, is there a way we can determine whether the file system is being
exported via nfsv4 is running, without using MS_I_VERSION?  Maybe a
new flag?  We could just disable lazytime if nfsd is running but
otherwise always increment i_version if lazytime is enabled.  My main
concern with i_version updates was not the in-memry update of
i_version, but rather the unnecessary extra metadata write "tax" that
would be inflicted on all users, including the many that aren't
serving files via NFSv4.

That way, if you shutdown the nfsv4 server, i_version would still be
updated, but we wouldn't be forcing the writes to disk, but then when
nfs v4 server is updated again, the i_version tax would be paid again.

                                              - Ted

<Prev in Thread] Current Thread [Next in Thread>