[Top] [All Lists]

Re: [PATCH 1/4] fs: split update_time() into update_time() and write_tim

To: dsterba@xxxxxxx, Chris Mason <clm@xxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 1/4] fs: split update_time() into update_time() and write_time()
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Mon, 24 Nov 2014 12:22:16 -0500
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date; bh=gxqpshWIt5Hsqw2C4lA4wUadqs/028f73IaMgzrRnmI=; b=oBg90FCBGnxNdkzZaIJpA4TmKHigDu3Tx2f/Mmp0VtVfkP4Iuznq7EShrkQGHc1z7duTY9vT3L777kAp2jOA88fQS+jd0QxEOejP8jkS0/NxO31RDahkMFItRBV6BG8a82Rp7ODKhIcApPvUHOZnP7cjPEf2lz+88zqQbEF8MVU=;
In-reply-to: <20141124163830.GA26471@xxxxxxxxxxxxx>
References: <1416599964-21892-1-git-send-email-tytso@xxxxxxx> <1416599964-21892-2-git-send-email-tytso@xxxxxxx> <1416600528.24312.10@xxxxxxxxxxxxxxxxxxxx> <20141121214245.GG7112@xxxxxxxxx> <20141124163830.GA26471@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Mon, Nov 24, 2014 at 05:38:30PM +0100, David Sterba wrote:
> It is necessary and the whole .update_time callback was added
> intentionally, see commits
> c3b2da314834499f34cba94f7053e55f6d6f92d8
> fs: introduce inode operation ->update_time
> e41f941a23115e84a8550b3d901a13a14b2edc2f
> Btrfs: move over to use ->update_time

Being able to signal an error if the time update fails is still
possible even if we drop update_time(), because the new write_time()
function will return an error.

> 2bc5565286121d2a77ccd728eb3484dff2035b58
> Btrfs: don't update atime on RO subvolumes

Yes, but this doesn't answer my question about other places where the
VFS is only checking MS_RDONLY and MNT_READONLY besides just
update_atime().  Maybe we should be exposing an "is_readonly(inode)"
inode operations function to address this?

                                                - Ted

<Prev in Thread] Current Thread [Next in Thread>