| To: | Theodore Ts'o <tytso@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/4] fs: split update_time() into update_time() and write_time() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 24 Nov 2014 07:21:01 -0800 |
| Cc: | linux-fsdevel@xxxxxxxxxxxxxxx, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1416599964-21892-2-git-send-email-tytso@xxxxxxx> |
| References: | <1416599964-21892-1-git-send-email-tytso@xxxxxxx> <1416599964-21892-2-git-send-email-tytso@xxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
On Fri, Nov 21, 2014 at 02:59:21PM -0500, Theodore Ts'o wrote: > We needed to preserve update_time() because btrfs wants to have a > special btrfs_root_readonly() check; otherwise we could drop the > update_time() inode operation entirely. Can't btrfs just set the immutable flag on every inode that is read when the root has the BTRFS_ROOT_SUBVOL_RDONLY flag? That would cut down the places that need this check to the ioctl path so that we prevent users from clearling the immutable flag. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH-v2 3/5] vfs: don't let the dirty time inodes get more than a day stale, Rasmus Villemoes |
|---|---|
| Next by Date: | Re: [PATCH 1/4] fs: split update_time() into update_time() and write_time(), Theodore Ts'o |
| Previous by Thread: | Re: [PATCH 1/4] fs: split update_time() into update_time() and write_time(), David Sterba |
| Next by Thread: | Re: [PATCH 1/4] fs: split update_time() into update_time() and write_time(), Theodore Ts'o |
| Indexes: | [Date] [Thread] [Top] [All Lists] |