[Top] [All Lists]

Re: [PATCH 1/4] fs: split update_time() into update_time() and write_tim

To: Chris Mason <clm@xxxxxx>
Subject: Re: [PATCH 1/4] fs: split update_time() into update_time() and write_time()
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Fri, 21 Nov 2014 16:42:45 -0500
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=h83B1VNBulViBYHWhxEbj8rRdNNlwnqdkA9tlDc2FOg=; b=hZ7mfD7+fzIWk6vsz27qrbcXi/kK2zsUuxmxOMrTV29269ZmVBO3GYhE6rEZAFRh6ZRKlSofr4Bp1hRClLavWMMtkOlAag9ivmtlxwcx3g9e7/JO2fUh4HK3Ch3EQOTFik4KaZwoayiFU5vb6aYNfeAbr/HQ8zFH2r96mzLNB4M=;
In-reply-to: <1416600528.24312.10@xxxxxxxxxxxxxxxxxxxx>
References: <1416599964-21892-1-git-send-email-tytso@xxxxxxx> <1416599964-21892-2-git-send-email-tytso@xxxxxxx> <1416600528.24312.10@xxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
Out of curiosity, why does btrfs_update_time() need to call
btrfs_root_readonly()?  Why can't it just depend on the
__mnt_want_write() call in touch_atime()?

Surely if there are times when it's not OK to write into a btrfs file
system and mnt_is_readonly() returns false, the VFS is going to get
very confused abyway.

If the btrfs_update_time() is not necessary, then we could drop
btrfs_update_time() and update_time() from the inode operations
entirely, and depend on the VFS-level code in update_time().

                                           - Ted

<Prev in Thread] Current Thread [Next in Thread>