xfs
[Top] [All Lists]

Re: [PATCH 07/11] ext4: Use generic helpers for quotaon and quotaoff

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 07/11] ext4: Use generic helpers for quotaon and quotaoff
From: Jan Kara <jack@xxxxxxx>
Date: Tue, 18 Nov 2014 17:07:26 +0100
Cc: Jan Kara <jack@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20141113173600.GB31481@xxxxxxxxxxxxx>
References: <1415739865-2438-1-git-send-email-jack@xxxxxxx> <1415739865-2438-8-git-send-email-jack@xxxxxxx> <20141113173600.GB31481@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu 13-11-14 09:36:00, Christoph Hellwig wrote:
> >  static const struct quotactl_ops ext4_qctl_sysfile_operations = {
> > -   .quota_on_meta  = ext4_quota_on_sysfile,
> > -   .quota_off      = ext4_quota_off_sysfile,
> > +   .sysquota_on    = dquot_sysquota_on,
> > +   .sysquota_off   = dquot_sysquota_off,
> >     .quota_sync     = dquot_quota_sync,
> >     .get_info       = dquot_get_dqinfo,
> >     .set_info       = dquot_set_dqinfo,
> 
> This vector now only has generic dquot_ methods.  Maybe move the
> vector to fs/quota/dquot.c and allow multiple filesystems to share it?
  Right. ocfs2 actually has the same vector now. I'll unify it.

                                                                Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR

<Prev in Thread] Current Thread [Next in Thread>