xfs
[Top] [All Lists]

Re: [PATCH 2/2] Add support to RENAME_EXCHANGE flag V7

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 2/2] Add support to RENAME_EXCHANGE flag V7
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 14 Nov 2014 12:57:44 -0600
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1415989940-20004-3-git-send-email-cmaiolino@xxxxxxxxxx>
References: <1415989940-20004-1-git-send-email-cmaiolino@xxxxxxxxxx> <1415989940-20004-3-git-send-email-cmaiolino@xxxxxxxxxx>
On 11/14/14 12:32 PM, Carlos Maiolino wrote:
> Adds a new function named xfs_cross_rename(), responsible to handle requests
> from sys_renameat2() using RENAME_EXCHANGE flag.

I really hate to do this, but, here:

> +     /*
> +     * If we're renaming one or more directories across different parents,
> +     * update the respective ".." entries (and link counts) to match the new
> +     * parents.
> +     */

and here:
 
>       /*
> +      * Handle RENAME_EXCHANGE flags
> +     */

there are whitespace issues w/ the comments (need a " " before the "*")

who knows, maybe Dave can fix them on commit ;)

-Eric

<Prev in Thread] Current Thread [Next in Thread>