xfs
[Top] [All Lists]

Re: [PATCH 07/11] ext4: Use generic helpers for quotaon and quotaoff

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH 07/11] ext4: Use generic helpers for quotaon and quotaoff
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 13 Nov 2014 09:36:00 -0800
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1415739865-2438-8-git-send-email-jack@xxxxxxx>
References: <1415739865-2438-1-git-send-email-jack@xxxxxxx> <1415739865-2438-8-git-send-email-jack@xxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
>  static const struct quotactl_ops ext4_qctl_sysfile_operations = {
> -     .quota_on_meta  = ext4_quota_on_sysfile,
> -     .quota_off      = ext4_quota_off_sysfile,
> +     .sysquota_on    = dquot_sysquota_on,
> +     .sysquota_off   = dquot_sysquota_off,
>       .quota_sync     = dquot_quota_sync,
>       .get_info       = dquot_get_dqinfo,
>       .set_info       = dquot_set_dqinfo,

This vector now only has generic dquot_ methods.  Maybe move the
vector to fs/quota/dquot.c and allow multiple filesystems to share it?

<Prev in Thread] Current Thread [Next in Thread>