xfs
[Top] [All Lists]

Re: [PATCH 4/9] xfsdump: remove pointless if (dirty);

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH 4/9] xfsdump: remove pointless if (dirty);
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 13 Nov 2014 11:35:18 -0600
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1415818638-32700-5-git-send-email-sandeen@xxxxxxxxxx>
References: <1415818638-32700-1-git-send-email-sandeen@xxxxxxxxxx> <1415818638-32700-5-git-send-email-sandeen@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 11/12/14 12:57, Eric Sandeen wrote:
"dirty" seems to be a remnant of unfinished code; other bits of
it are there but commented out, so comment out "if (dirty);" as
well, which is a no-op if statement which can't be true.

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---
  inventory/inv_stobj.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/inventory/inv_stobj.c b/inventory/inv_stobj.c
index becac17..84b15d9 100644
--- a/inventory/inv_stobj.c
+++ b/inventory/inv_stobj.c
@@ -976,7 +976,9 @@ stobj_delete_mobj(int fd,

                }
                free ( mfiles );
+/*
                if ( dirty );
+*/
        }

        free ( strms );

Why not remove all the references to dirty in the function?
Like you said, it doesn't do anything.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>