xfs
[Top] [All Lists]

Re: kernel BUG at drivers/block/virtio_blk.c:172!

To: Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: kernel BUG at drivers/block/virtio_blk.c:172!
From: Dongsu Park <dongsu.park@xxxxxxxxxxxxxxxx>
Date: Thu, 13 Nov 2014 12:04:15 +0100
Cc: Ming Lei <tom.leiming@xxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Jeff Layton <jlayton@xxxxxxxxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, Lukas Czerner <lczerner@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Linux Virtualization <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5463A478.20603@xxxxxxxxx>
References: <20141107080416.0837a88c@xxxxxxxxxxxxxxxxxxxxxxx> <87bnofnzop.fsf@xxxxxxxxxxxxxxx> <54614AE7.2080204@xxxxxxxxx> <CACVXFVOgRMqCUASOaXQ7ys8yiKZFEH5SA-+mV=H0uvHuGseENQ@xxxxxxxxxxxxxx> <20141111154250.GA16906@xxxxxxxxx> <CACVXFVNXSmw=Gu_9JAtpF3uxupSMr4kN2ge-jnZMxZAMcaHrfw@xxxxxxxxxxxxxx> <5463A478.20603@xxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On 12.11.2014 11:18, Jens Axboe wrote:
> On 11/11/2014 09:42 AM, Ming Lei wrote:
> > The attached patch should fix the problem, and hope it is the last one, :-)
> 
> Dongsu and Jeff, any of you test this variant? I think this is the last
> one, at least I hope so as well...

Yes, I've just tested it again with the Ming's patch.
It passed a full cycle of xfstests: No crash, no particular regression.
The code in blk_recount_segments() seems to make sense too.

Thanks! ;-)
Dongsu

<Prev in Thread] Current Thread [Next in Thread>