xfs
[Top] [All Lists]

Re: [PATCH 2/9] xfsdump: Fix overflow of "question" string in Media_prom

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH 2/9] xfsdump: Fix overflow of "question" string in Media_prompt_erase()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 12 Nov 2014 10:58:45 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1415818638-32700-3-git-send-email-sandeen@xxxxxxxxxx>
References: <1415818638-32700-1-git-send-email-sandeen@xxxxxxxxxx> <1415818638-32700-3-git-send-email-sandeen@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Wed, Nov 12, 2014 at 12:57:11PM -0600, Eric Sandeen wrote:
> The string we were sprintf'ing is trivially longer than the array
> we allocated for it.
> 
> Allocate something big enough, and snprintf to avoid overflow

How about switching it to asprintf() to get rid of that dangerous static
buffer entirely?

<Prev in Thread] Current Thread [Next in Thread>