| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 9/9] xfsdump: fix uninit ackstr in content_mediachange_query() |
| From: | Eric Sandeen <sandeen@xxxxxxxxxx> |
| Date: | Wed, 12 Nov 2014 12:57:18 -0600 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1415818638-32700-1-git-send-email-sandeen@xxxxxxxxxx> |
| References: | <1415818638-32700-1-git-send-email-sandeen@xxxxxxxxxx> |
Today, this sends an uninitialized ackstr[0] to be mlog'd -
who knows what we get out of it. Other places follow this
"count = 0, string = "\n"" pattern which seemsa bit odd, but
better than printing uninitialized memory.
To be completely honest, I have no test for this.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
restore/content.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/restore/content.c b/restore/content.c
index c99aed7..bc5b398 100644
--- a/restore/content.c
+++ b/restore/content.c
@@ -2915,6 +2915,7 @@ content_mediachange_query( void )
bagp = 0;
}
ackcnt = 0;
+ ackstr[ ackcnt++ ] = "\n";
dlog_multi_ack( ackstr,
ackcnt );
querycnt = 0;
--
1.7.1
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 4/9] xfsdump: remove pointless if (dirty);, Eric Sandeen |
|---|---|
| Next by Date: | [PATCH 1/9] xfsdump: don't try to close fd from failed open, Eric Sandeen |
| Previous by Thread: | Re: [PATCH 4/9] xfsdump: remove pointless if (dirty);, Mark Tinguely |
| Next by Thread: | Re: [PATCH 9/9] xfsdump: fix uninit ackstr in content_mediachange_query(), Mark Tinguely |
| Indexes: | [Date] [Thread] [Top] [All Lists] |