| To: | Jan Kara <jack@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 03/11] xfs: Remove some useless flags tests |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 12 Nov 2014 10:26:34 +1100 |
| Cc: | linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1415739865-2438-4-git-send-email-jack@xxxxxxx> |
| References: | <1415739865-2438-1-git-send-email-jack@xxxxxxx> <1415739865-2438-4-git-send-email-jack@xxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Nov 11, 2014 at 10:04:17PM +0100, Jan Kara wrote: > 'flags' have XFS_ALL_QUOTA_ACCT cleared immediately on function entry. > There's no point in checking these bits later in the function. Also > because we check something is going to change, we know some enforcement > bits are being added and thus there's no point in testing that later. > > Signed-off-by: Jan Kara <jack@xxxxxxx> Looks sane. I'll pick this up straight away. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 02/11] xfs: Remove unused variable in xfs_qm_scall_quotaon(), Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 01/11] xfs: Remove useless test, Dave Chinner |
| Previous by Thread: | [PATCH 03/11] xfs: Remove some useless flags tests, Jan Kara |
| Next by Thread: | [PATCH 08/11] ocfs2: Use generic helpers for quotaon and quotaoff, Jan Kara |
| Indexes: | [Date] [Thread] [Top] [All Lists] |