Re: [PATCH 02/11] xfs: Remove unused variable in xfs_qm_scall

To:	Jan Kara <jack@xxxxxxx>
Subject:	Re: [PATCH 02/11] xfs: Remove unused variable in xfs_qm_scall_quotaon()
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 12 Nov 2014 10:23:33 +1100
Cc:	linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1415739865-2438-3-git-send-email-jack@xxxxxxx>
References:	<1415739865-2438-1-git-send-email-jack@xxxxxxx> <1415739865-2438-3-git-send-email-jack@xxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Nov 11, 2014 at 10:04:16PM +0100, Jan Kara wrote:
> sbflags variable in xfs_qm_scall_quotaon() was practically unused (we
> only set it to constant at one place and used it elsewhere). Remove it.
> 
> Signed-off-by: Jan Kara <jack@xxxxxxx>

I have patches in my queue that change the superblock logging
quite a bit and remove the functionality you're changing in this
patch, so eventually you'll be able to drop this patch.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 06/11] quota: Add ->sysquota_{on,off} callbacks for VFS quotas, (continued) [PATCH 06/11] quota: Add ->sysquota_{on,off} callbacks for VFS quotas, Jan Kara [PATCH 07/11] ext4: Use generic helpers for quotaon and quotaoff, Jan Kara Re: [PATCH 07/11] ext4: Use generic helpers for quotaon and quotaoff, Christoph Hellwig Re: [PATCH 07/11] ext4: Use generic helpers for quotaon and quotaoff, Jan Kara [PATCH 11/11] quota: Store maximum space limit in bytes, Jan Kara [PATCH 04/11] quota: Split ->set_xstate callback into two, Jan Kara Re: [PATCH 04/11] quota: Split ->set_xstate callback into two, Christoph Hellwig Re: [PATCH 04/11] quota: Split ->set_xstate callback into two, Jan Kara [PATCH 09/11] quota: Remove quota_on_meta callback, Jan Kara [PATCH 02/11] xfs: Remove unused variable in xfs_qm_scall_quotaon(), Jan Kara Re: [PATCH 02/11] xfs: Remove unused variable in xfs_qm_scall_quotaon(), Dave Chinner <= [PATCH 01/11] xfs: Remove useless test, Jan Kara Re: [PATCH 01/11] xfs: Remove useless test, Dave Chinner [PATCH 05/11] quota: Wire up ->sysquota_{on,off} callbacks into Q_QUOTA{ON,OFF}, Jan Kara [PATCH 10/11] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units, Jan Kara Re: [PATCH 10/11] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units, Dave Chinner

Previous by Date:	Re: [PATCH v2] xfs: replace global xfslogd wq with per-mount xfs-iodone wq, Dave Chinner
Next by Date:	Re: [PATCH 03/11] xfs: Remove some useless flags tests, Dave Chinner
Previous by Thread:	[PATCH 02/11] xfs: Remove unused variable in xfs_qm_scall_quotaon(), Jan Kara
Next by Thread:	[PATCH 01/11] xfs: Remove useless test, Jan Kara
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 02/11] xfs: Remove unused variable in xfs_qm_scall_quotaon()