[Top] [All Lists]

Re: [PATCH 0/6 v2] xfs: fix the bulkstat mess

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 0/6 v2] xfs: fix the bulkstat mess
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 5 Nov 2014 17:07:28 +1100
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1415145921-31507-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1415145921-31507-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 05, 2014 at 11:05:15AM +1100, Dave Chinner wrote:
> Hi folks, this is version 2 of the bulkstat fixup series first
> posted here:
> http://oss.sgi.com/archives/xfs/2014-11/msg00057.html
> Version 2 fixes the issues Brian found during review:
> - chunk formatter error leakage (patch 3)
> - moved main loop chunk formatter error handling from patch 4 to
>   patch 5
> - reworks last_agino updating in patch 6 to do post-formatting
>   updates and added comments.
> Comeents and testing welcome.

I'm not 100% convinced that this fixes all the problems. I just
created, dumped and restored a 10 million inode filesystem (about
50GB of dump file) and I found 102 missing files in the dump with no
errors from xfsdump or xfsrestore.

The files are missing from just 4 directories out of about 1000
directories containing equal numbers of files, so its not a common
trigger whatever the issue is. I'll keep digging...


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>