xfs
[Top] [All Lists]

Re: [PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse

To: Fanael Linithien <fanael4@xxxxxxxxx>
Subject: Re: [PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse inode chunks
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Mon, 3 Nov 2014 17:34:08 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <CA+o=1OWm3XWUgNXR1_CravnEBL8fD8dwyMvY4CN9rbAsw0Q4Sw@xxxxxxxxxxxxxx>
References: <1415031146-9107-1-git-send-email-bfoster@xxxxxxxxxx> <1415031146-9107-6-git-send-email-bfoster@xxxxxxxxxx> <CA+o=1OWm3XWUgNXR1_CravnEBL8fD8dwyMvY4CN9rbAsw0Q4Sw@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Mon, Nov 03, 2014 at 11:12:12PM +0100, Fanael Linithien wrote:
> 2014-11-03 17:12 GMT+01:00 Brian Foster <bfoster@xxxxxxxxxx>:
> >
> > +static inline bool xfs_inobt_issparse(uint16_t holemask)
> > +{
> > +       return holemask == 0 ? false : true;
> > +}
> 
> Surely that should be "return holemask != 0;"?
> 

ir_holemask bits are set for holes in the inode chunk and unset for
allocated regions. This means that ir_holemask == 0 for a normal,
fully-allocated chunk and != 0 otherwise (some bits are set to indicate
the chunk has a hole). Check out the commit log for patch 4 for
reasoning.

Brian

> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>