Re: [PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse

Subject:	Re: [PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse inode chunks
From:	Fanael Linithien <fanael4@xxxxxxxxx>
Date:	Mon, 3 Nov 2014 23:12:12 +0100
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:cc :content-type; bh=L+XSv6+SbSI0sJSb+ou0N3F5ynXIjNz8N2OkgoCHfWc=; b=1KOeG34KiFPp5DOYK8loRhcNs+/J6P+RoUh9WCIJZGfhNkEtfFbVhOnBPTNOaW+xFw Laawlqehe3GPRHyoctoRvqVY7KyQvgr088iAW37IguYJExd5Ld4cnK3QkXhSu/3iTZQ4 SoelvF5tFR+9YLsCXyRhGEIV183/fs8xtm3Kw8oCrkqrrV2Zsh/evYtoGz2sg505RQrt 01yyTVHmjh2uGtA94yYkO0KgHCWfS+lIOoYP1zwLt14LFjjdSYyToKjUsigrf0QfyGsz 4wFW8jbcfVoveulb8BhYB3OeyY/CoNOsmF5p9QHuBHVIyKJ6U882EZQJztDJJXVg2AaK IBbA==
In-reply-to:	<1415031146-9107-6-git-send-email-bfoster@xxxxxxxxxx>
References:	<1415031146-9107-1-git-send-email-bfoster@xxxxxxxxxx> <1415031146-9107-6-git-send-email-bfoster@xxxxxxxxxx>

2014-11-03 17:12 GMT+01:00 Brian Foster <bfoster@xxxxxxxxxx>:
>
> +static inline bool xfs_inobt_issparse(uint16_t holemask)
> +{
> +       return holemask == 0 ? false : true;
> +}

Surely that should be "return holemask != 0;"?

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH v2 00/17] xfs: sparse inode chunks, Brian Foster [PATCH v2 14/17] xfs: skip unallocated regions of inode chunks in xfs_ifree_cluster(), Brian Foster [PATCH v2 06/17] xfs: pass inode count through ordered icreate log item, Brian Foster [PATCH v2 04/17] xfs: introduce inode record hole mask for sparse inode chunks, Brian Foster [PATCH v2 12/17] xfs: update free inode record logic to support sparse inode records, Brian Foster [PATCH v2 09/17] xfs: allocate sparse inode chunks on full chunk allocation failure, Brian Foster [PATCH v2 10/17] xfs: helpers to convert holemask to/from generic bitmap, Brian Foster [PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse inode chunks, Brian Foster Re: [PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse inode chunks, Fanael Linithien <= Re: [PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse inode chunks, Brian Foster Re: [PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse inode chunks, Fanael Linithien Re: [PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse inode chunks, Dave Chinner Re: [PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse inode chunks, Brian Foster Re: [PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse inode chunks, Brian Foster [PATCH v2 15/17] xfs: use actual inode count for sparse records in bulkstat/inumbers, Brian Foster [PATCH v2 11/17] xfs: filter out sparse regions from individual inode allocation, Brian Foster [PATCH v2 03/17] xfs: define sparse inode chunks v5 sb feature bit and helper function, Brian Foster [PATCH v2 02/17] xfs: use sparse chunk alignment for min. inode allocation requirement, Brian Foster [PATCH v2 01/17] xfs: add sparse inode chunk alignment superblock field, Brian Foster

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:	Re: clone of filesystem across network preserving ionodes, Dave Chinner
Next by Date:	Re: your patch "mm: Remove false WARN_ON from pagecache_isize_extended()", Dave Chinner
Previous by Thread:	[PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse inode chunks, Brian Foster
Next by Thread:	Re: [PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse inode chunks, Brian Foster
Indexes:	[Date] [Thread] [Top] [All Lists]

Previous by Date:

Re: clone of filesystem across network preserving ionodes, Dave Chinner

Next by Date:

Re: your patch "mm: Remove false WARN_ON from pagecache_isize_extended()", Dave Chinner

Previous by Thread:

[PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse inode chunks, Brian Foster

Next by Thread:

Re: [PATCH v2 05/17] xfs: create macros/helpers for dealing with sparse inode chunks, Brian Foster

Indexes:

[Date] [Thread] [Top] [All Lists]