[Top] [All Lists]

Re: [PATCH 0/2] repair: fix AGFL rebuild problem

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 0/2] repair: fix AGFL rebuild problem
From: Barkley Vowk <bvowk@xxxxxxx>
Date: Wed, 29 Oct 2014 11:23:06 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=box.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=9pxx0UHPJvs3La8rSpBJbW5AViaK+QbLBw/SxAmBJBY=; b=XVF/wezqF/Cbv9gnXJrBh9jsDhlvj6iHBoGVinezswvdysx+f8TMo71d/PkQRfBFAi aEnFUrwJD1/NuvazYN1twOSvzf30zCu7u21z0ddWq4QP+ttdP7I3ElBxTnNR2ZTRgydU ucDVJ+P8fgRDTlV/89LfWQl+IPUrN8+1gcTsM=
In-reply-to: <1414552144-12627-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1414552144-12627-1-git-send-email-david@xxxxxxxxxxxxx>
These patches fixed my issue.Â


On Tue, Oct 28, 2014 at 8:09 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
Hi folks,

The following two patches fix a repair rebuild issue that was
reported to me. xfs_repair would appear to succeed, but subsequent
runs would report a freespace mismatch and then on mount trigger
a corruption error on the first allocation from AG 0.

The problem as that the AGFL was not being correctly rebuilt due to
a very particular freespace pattern in AG 0 which required free
blocks in the AGFL to populate an empty AGFL. reapir silently
ignored this error, so it triggered allocation corruption errors
when the same AGFL fixup attempt failed on a mounted filesystem.

The fix is relatively straight forward, as is the fixes to the
tracing code that I had to make before i could track down the issue.


<Prev in Thread] Current Thread [Next in Thread>