xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: enable sparse checking

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: enable sparse checking
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 27 Oct 2014 08:25:21 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20141027094800.GB31604@xxxxxxxxxxxxx>
References: <54498F4A.9030207@xxxxxxxxxx> <20141024061718.GA15341@xxxxxxxxxxxxx> <544A59F7.4070601@xxxxxxxxxxx> <20141024154058.GA10788@xxxxxxxxxxxxx> <544A74E7.1060502@xxxxxxxxxxx> <20141027094800.GB31604@xxxxxxxxxxxxx>
On 10/27/14 4:48 AM, Christoph Hellwig wrote:
> On Fri, Oct 24, 2014 at 10:48:55AM -0500, Eric Sandeen wrote:
>> On 10/24/14 10:40 AM, Christoph Hellwig wrote:
>>> strong opinion.  It's not like your patch prevents me from using CC=cgcc
>>
>> To get endian checking with your method, you'd need to edit
>> the Makefile to add the -D define, right?
> 
> That's a kernel special, I just did a test run using CC=cgcc and I get
> endianess warnings:
> 
> rdwr.c:190:21: warning: incorrect type in assignment (different base types)
> rdwr.c:190:21:    expected restricted __le32 [usertype] h_crc
> rdwr.c:190:21:    got restricted __be32 [usertype] <noident>

Oh, without an extra define?  Hrm.  Ok I guess I need to read
up on what enables it.

I did send a couple patches to fix some of these.  Sorry, didn't
do it in a series:

[PATCH] xfsprogs: fix endian mishap in xfs_dialloc_ag()
[PATCH] xfsprogs: fix harmless sparse endian nit

-Eric

<Prev in Thread] Current Thread [Next in Thread>