xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: two more completely harmless sparse nits

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: two more completely harmless sparse nits
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Mon, 27 Oct 2014 07:26:10 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5449964F.1040504@xxxxxxxxxx>
References: <5449964F.1040504@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Thu, Oct 23, 2014 at 06:59:11PM -0500, Eric Sandeen wrote:
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

> 
> diff --git a/repair/prefetch.c b/repair/prefetch.c
> index 65f8456..7ea0d36 100644
> --- a/repair/prefetch.c
> +++ b/repair/prefetch.c
> @@ -171,7 +171,7 @@ pf_read_bmbt_reclist(
>       struct xfs_buf_map      map_array[MAP_ARRAY_SZ];
>       struct xfs_buf_map      *map = map_array;
>       int                     max_extents = MAP_ARRAY_SZ;
> -     int                     nmaps = 0;;
> +     int                     nmaps = 0;
>       unsigned int            len = 0;
>       int                     ret = 0;
>  
> diff --git a/rtcp/xfs_rtcp.c b/rtcp/xfs_rtcp.c
> index b81b1e1..5f26a62 100644
> --- a/rtcp/xfs_rtcp.c
> +++ b/rtcp/xfs_rtcp.c
> @@ -25,7 +25,7 @@ int pflag;
>  char *progname;
>  
>  void
> -usage()
> +usage(void)
>  {
>       fprintf(stderr, _("%s [-e extsize] [-p] [-V] source target\n"), 
> progname);
>       exit(2);
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>