xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: fix endian mishap in xfs_dialloc_ag()

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: fix endian mishap in xfs_dialloc_ag()
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Mon, 27 Oct 2014 07:25:54 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <54498FE9.4000103@xxxxxxxxxx>
References: <54498FE9.4000103@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Thu, Oct 23, 2014 at 06:31:53PM -0500, Eric Sandeen wrote:
> Fixes a regression introduced by:
> 
> 88fc730 xfs: use and update the finobt on inode allocation
> 
> which passed the non-swapped version of agi->agi_newino to
> xfs_inobt_lookup()
> 
> Caught by make C=2, ftw!
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

> 
> diff --git a/libxfs/xfs_ialloc.c b/libxfs/xfs_ialloc.c
> index 5462c54..b20a9ec 100644
> --- a/libxfs/xfs_ialloc.c
> +++ b/libxfs/xfs_ialloc.c
> @@ -1057,7 +1057,8 @@ xfs_dialloc_ag(
>                * most recently allocated inode.
>                */
>               if (agi->agi_newino != cpu_to_be32(NULLAGINO)) {
> -                     error = xfs_inobt_lookup(cur, agi->agi_newino,
> +                     error = xfs_inobt_lookup(cur,
> +                                              be32_to_cpu(agi->agi_newino),
>                                                XFS_LOOKUP_EQ, &i);
>                       if (error)
>                               goto error_cur;
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>