xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: enable sparse checking

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: enable sparse checking
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 27 Oct 2014 02:48:00 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <544A74E7.1060502@xxxxxxxxxxx>
References: <54498F4A.9030207@xxxxxxxxxx> <20141024061718.GA15341@xxxxxxxxxxxxx> <544A59F7.4070601@xxxxxxxxxxx> <20141024154058.GA10788@xxxxxxxxxxxxx> <544A74E7.1060502@xxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Oct 24, 2014 at 10:48:55AM -0500, Eric Sandeen wrote:
> On 10/24/14 10:40 AM, Christoph Hellwig wrote:
> > strong opinion.  It's not like your patch prevents me from using CC=cgcc
> 
> To get endian checking with your method, you'd need to edit
> the Makefile to add the -D define, right?

That's a kernel special, I just did a test run using CC=cgcc and I get
endianess warnings:

rdwr.c:190:21: warning: incorrect type in assignment (different base types)
rdwr.c:190:21:    expected restricted __le32 [usertype] h_crc
rdwr.c:190:21:    got restricted __be32 [usertype] <noident>

log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64

There's also tons of noise that should be easily upgradeable, but let me
check latests xfsprogs first..

<Prev in Thread] Current Thread [Next in Thread>