xfs
[Top] [All Lists]

[PATCH] xfsprogs: fix harmless sparse endian nit

To: xfs-oss <xfs@xxxxxxxxxxx>
Subject: [PATCH] xfsprogs: fix harmless sparse endian nit
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Thu, 23 Oct 2014 18:44:49 -0500
Delivered-to: xfs@xxxxxxxxxxx
h_crc is __le32 but cpu_to_be32() is... __be32.  So sparse
complains, even though it's harmless.

Although sparse is smart about bare 0s, and we could
drop the swap, other places explicitly swap to keep
things clear (I guess?) so "swap" the 0 with the proper
routine.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---

diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
index 9ee89d3..dd8baa6 100644
--- a/libxfs/rdwr.c
+++ b/libxfs/rdwr.c
@@ -187,7 +187,7 @@ libxfs_log_header(
                head->h_len = cpu_to_be32(sunit - BBSIZE);
        else
                head->h_len = cpu_to_be32(20);
-       head->h_crc = cpu_to_be32(0);
+       head->h_crc = cpu_to_le32(0);
        head->h_prev_block = cpu_to_be32(-1);
        head->h_num_logops = cpu_to_be32(1);
        head->h_cycle_data[0] = cpu_to_be32(0xb0c0d0d0);

<Prev in Thread] Current Thread [Next in Thread>