[Top] [All Lists]

Re: [PATCH 02/12] quota: Allow each filesystem to specify which quota ty

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH 02/12] quota: Allow each filesystem to specify which quota types it supports
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 22 Oct 2014 18:29:15 +0200
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, cluster-devel@xxxxxxxxxx, Steven Whitehouse <swhiteho@xxxxxxxxxx>, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, ocfs2-devel@xxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, Jeff Mahoney <jeffm@xxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, tytso@xxxxxxx, viro@xxxxxxxxxxxxxxxxxx, hch@xxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1413902316-17997-3-git-send-email-jack@xxxxxxx>
References: <1413902316-17997-1-git-send-email-jack@xxxxxxx> <1413902316-17997-3-git-send-email-jack@xxxxxxx>
User-agent: Mutt/1.5.17 (2007-11-01)
On Tue, Oct 21, 2014 at 04:38:26PM +0200, Jan Kara wrote:
> Currently all filesystems supporting VFS quota support user and group
> quotas. With introduction of project quotas this is going to change so
> make sure filesystem isn't called for quota type it doesn't support by
> introduction of a bitmask determining which quota types each filesystem
> supports.

Why don't you keep this bitmask in the dquot.c instead of pushing it
to the caller?  So far usage of s_dquot is mostly confined to dquot.c
(with a few leaks to the filesystems using it), so keeping it that
way seems like a good idea.

<Prev in Thread] Current Thread [Next in Thread>