Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode

To:	Jan Kara <jack@xxxxxxx>
Subject:	Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sat, 18 Oct 2014 08:17:38 -0700
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, cluster-devel@xxxxxxxxxx, Steven Whitehouse <swhiteho@xxxxxxxxxx>, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, ocfs2-devel@xxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, Jeff Mahoney <jeffm@xxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, tytso@xxxxxxx, viro@xxxxxxxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20141017192428.GA19788@xxxxxxxxxxxxx>
References:	<1412952910-7142-1-git-send-email-jack@xxxxxxx> <20141011133452.GA29004@xxxxxxxxxxxxx> <20141017192428.GA19788@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

To:

Jan Kara <jack@xxxxxxx>

Subject:

Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode

From:

Christoph Hellwig <hch@xxxxxxxxxxxxx>

Date:

Sat, 18 Oct 2014 08:17:38 -0700

Cc:

Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, cluster-devel@xxxxxxxxxx, Steven Whitehouse <swhiteho@xxxxxxxxxx>, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, ocfs2-devel@xxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, Jeff Mahoney <jeffm@xxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, tytso@xxxxxxx, viro@xxxxxxxxxxxxxxxxxx

Delivered-to:

xfs@xxxxxxxxxxx

In-reply-to:

<20141017192428.GA19788@xxxxxxxxxxxxx>

References:

<1412952910-7142-1-git-send-email-jack@xxxxxxx> <20141011133452.GA29004@xxxxxxxxxxxxx> <20141017192428.GA19788@xxxxxxxxxxxxx>

User-agent:

Mutt/1.5.23 (2014-03-12)

On Fri, Oct 17, 2014 at 09:24:28PM +0200, Jan Kara wrote:
>   I don't see the 4-bytes per inode saving, what am I missing? Frankly, I
> don't see a difference in readability but since you and Al agree on that I
> concede to your taste :)

It's the removal of s_inode_fields that saves 4 bytes.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 06/12] ext2: Convert to private i_dquot field, (continued) [PATCH 06/12] ext2: Convert to private i_dquot field, Jan Kara [PATCH 11/12] jfs: Convert to private i_dquot field, Jan Kara Re: [PATCH 11/12] jfs: Convert to private i_dquot field, Dave Kleikamp Re: [PATCH 11/12] jfs: Convert to private i_dquot field, Jan Kara Re: [PATCH 11/12] jfs: Convert to private i_dquot field, Dave Kleikamp [PATCH 12/12] vfs: Remove i_dquot field from inode, Jan Kara [PATCH 10/12] reiserfs: Convert to private i_dquot field, Jan Kara Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Christoph Hellwig Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Al Viro Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Jan Kara Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Christoph Hellwig <= Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Jan Kara Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Christoph Hellwig

Previous by Date:	Re: Problem about very high Average Read/Write Request Time, Emmanuel Florac
Next by Date:	Re: gather write metrics on multiple files, Stan Hoeppner
Previous by Thread:	Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Jan Kara
Next by Thread:	Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Jan Kara
Indexes:	[Date] [Thread] [Top] [All Lists]

Previous by Date:

Re: Problem about very high Average Read/Write Request Time, Emmanuel Florac

Next by Date:

Re: gather write metrics on multiple files, Stan Hoeppner

Previous by Thread:

Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Jan Kara

Next by Thread:

Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Jan Kara

Indexes:

[Date] [Thread] [Top] [All Lists]