Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode

xfs

Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode
From:	Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date:	Sun, 12 Oct 2014 19:53:16 +0100
Cc:	Jan Kara <jack@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, cluster-devel@xxxxxxxxxx, Steven Whitehouse <swhiteho@xxxxxxxxxx>, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, ocfs2-devel@xxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, Jeff Mahoney <jeffm@xxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, tytso@xxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20141011133452.GA29004@xxxxxxxxxxxxx>
References:	<1412952910-7142-1-git-send-email-jack@xxxxxxx> <20141011133452.GA29004@xxxxxxxxxxxxx>
Sender:	Al Viro <viro@xxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Sat, Oct 11, 2014 at 06:34:52AM -0700, Christoph Hellwig wrote:
> I still very much disagree with the s_inode_fields indirection.  Please
> find a patch below to remove it, and use a get_dquots super_block
> operation instead.  This leads to less and better readable code,
> and serves 4 bytes in every inode in the system.  Additionally the
> indirection could easily be optimized away by directly passing the
> dquot array in various functions, but for now I'd like to keep it
> simple.

Indeed.  This "array of offsets" approach is asking for trouble.  Please,
don't go there - playing that way with type safety is a bad idea.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 09/12] ocfs2: Convert to private i_dquot field, (continued) [PATCH 09/12] ocfs2: Convert to private i_dquot field, Jan Kara [PATCH 05/12] quota: Use optional inode field for i_dquot pointers, Jan Kara [PATCH 06/12] ext2: Convert to private i_dquot field, Jan Kara [PATCH 11/12] jfs: Convert to private i_dquot field, Jan Kara Re: [PATCH 11/12] jfs: Convert to private i_dquot field, Dave Kleikamp Re: [PATCH 11/12] jfs: Convert to private i_dquot field, Jan Kara Re: [PATCH 11/12] jfs: Convert to private i_dquot field, Dave Kleikamp [PATCH 12/12] vfs: Remove i_dquot field from inode, Jan Kara [PATCH 10/12] reiserfs: Convert to private i_dquot field, Jan Kara Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Christoph Hellwig Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Al Viro <= Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Jan Kara Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Christoph Hellwig Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Jan Kara Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Christoph Hellwig

Previous by Date:	[PATCH] xfs: fix agno increment in xfs_inumbers() loop, Eric Sandeen
Next by Date:	Re: dmesg error in xfs_aops.c on kernel 3.14.21, BillStuff
Previous by Thread:	Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Christoph Hellwig
Next by Thread:	Re: [PATCH 0/12 v2] Moving i_dquot out of struct inode, Jan Kara
Indexes:	[Date] [Thread] [Top] [All Lists]