Re: [PATCH 15/16] xfs: xfs_fs_geometry returns a number of bytes to copy

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Fri, Oct 03, 2014 at 05:05:09PM -0500, Ben Myers wrote:
> From: Ben Myers <bpm@xxxxxxx>
> 
> The versioned xfs_fsop_geom_t will be of variable size.  Make
> xfs_fs_geometry return the number of bytes to copy out to userspace for
> a given version of the structure.

xfs_fs_geometry() should be a void right now - it doesn't return any
error value at all.

Further, the size of the structure that is filled in is determined
by the version of the ioctl being called, not the xfs_fs_geometry()
function. Hence the caller already knows the size of the structure
being used, and hence does not need xfs_fs_geometry() to tell it
that information.

So I don't think this change is necessary.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx