xfs
[Top] [All Lists]

Re: [PATCH 15/16] xfs: xfs_fs_geometry returns a number of bytes to copy

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 15/16] xfs: xfs_fs_geometry returns a number of bytes to copy
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 7 Oct 2014 07:41:14 +1100
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, olaf@xxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20141003220508.GO1865@xxxxxxx>
References: <20141003214758.GY1865@xxxxxxx> <20141003220508.GO1865@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Oct 03, 2014 at 05:05:09PM -0500, Ben Myers wrote:
> From: Ben Myers <bpm@xxxxxxx>
> 
> The versioned xfs_fsop_geom_t will be of variable size.  Make
> xfs_fs_geometry return the number of bytes to copy out to userspace for
> a given version of the structure.

xfs_fs_geometry() should be a void right now - it doesn't return any
error value at all.

Further, the size of the structure that is filled in is determined
by the version of the ioctl being called, not the xfs_fs_geometry()
function. Hence the caller already knows the size of the structure
being used, and hence does not need xfs_fs_geometry() to tell it
that information.

So I don't think this change is necessary.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>