xfs
[Top] [All Lists]

Re: [PATCH 14/16] xfs: rename XFS_IOC_FSGEOM to XFS_IOC_FSGEOM_V2

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 14/16] xfs: rename XFS_IOC_FSGEOM to XFS_IOC_FSGEOM_V2
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 6 Oct 2014 15:38:59 -0500
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, olaf@xxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20141006203300.GC2301@dastard>
References: <20141003214758.GY1865@xxxxxxx> <20141003220435.GN1865@xxxxxxx> <20141006203300.GC2301@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Oct 07, 2014 at 07:33:00AM +1100, Dave Chinner wrote:
> On Fri, Oct 03, 2014 at 05:04:35PM -0500, Ben Myers wrote:
> > From: Ben Myers <bpm@xxxxxxx>
> > 
> > We'll be creating a new versioned XFS_IOC_FSGEOMETRY ioctl and structure
> > so rename the current revision to _V2.
> 
> Urk, no.
> 
> This will result in older applications picking up the new ioctl when
> they are rebuilt without having explicit support for the new ioctl.
> 
> Just create a new ioctl with a new name and modify applications to
> use it. If the kernel does not support the new ioctl, then fall back
> to the old one in userspace.

D'oh.  Yeah, ok.

<Prev in Thread] Current Thread [Next in Thread>