xfs
[Top] [All Lists]

Re: [PATCH] xfs: check for null dquot in xfs_quota_calc_throttle()

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: check for null dquot in xfs_quota_calc_throttle()
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 2 Oct 2014 09:25:59 +1000
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <542C28E5.506@xxxxxxxxxx>
References: <542C28E5.506@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 01, 2014 at 11:16:37AM -0500, Eric Sandeen wrote:
> Coverity spotted this.
> 
> Granted, we *just* checked xfs_inod_dquot() in the caller (by calling
> xfs_quota_need_throttle), but to be honest I don't know if this can
> race, and this is the only place we don't check the return value -
> and the check seems cheap and future-proof.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> Sorry for the handwavy commit log, if it's obvious that it can
> race, feel free to fix the description. ;)

Description changed simply to say:

... this is the only place we don't check the return value, but the
check is cheap and future-proof, so add it.

And so:

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>