[Top] [All Lists]

Re: [PATCH 2/2] xfs: only set extent size hint when asked

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: only set extent size hint when asked
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 2 Oct 2014 09:21:26 +1000
Cc: xfs@xxxxxxxxxxx, iusty@xxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20141001115959.GB53779@xxxxxxxxxxxxxxx>
References: <1412041565-18873-1-git-send-email-david@xxxxxxxxxxxxx> <1412041565-18873-3-git-send-email-david@xxxxxxxxxxxxx> <20141001115959.GB53779@xxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 01, 2014 at 07:59:59AM -0400, Brian Foster wrote:
> On Tue, Sep 30, 2014 at 11:46:05AM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Currently the extent size hint is set unconditionally in
> > xfs_ioctl_setattr(), even when the FSX_EXTSIZE flag is not set. This
> > means we can set values from uninitialised stack variables. Hence
> > only set the extent size hint from userspace when both the mask
> > falg is set and the inode has the XFS_DIFLAG_EXTSIZE flag set to
> > indicate that we should have an extent size hint set on the inode.
> > 
> I'm not sure what you mean here by FSX_EXTSIZE not being checked. It
> looks like FSX_EXTSIZE is checked before and after the patch.

Yup, I wrote the commit message, then did the fix and forgot to
update the message after I realised it was wrong. I've fixed the
commit message.

> Regardless, the fix looks Ok to me...
> Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>