xfs
[Top] [All Lists]

Re: [PATCH] xfs: kill time.h

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: kill time.h
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 29 Sep 2014 03:44:43 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1411954911-12278-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1411954911-12278-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Mon, Sep 29, 2014 at 11:41:51AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The typedef for timespecs and nanotime() are completely unnecessary,
> and delay() can be moved to fs/xfs/linux.h, which means this file
> can go away.

Looks good, but shouldn't we just kill delay(), too? There's just
11 callers, and none of them in libxfs.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>