[Top] [All Lists]

Re: [PATCH] xfs: compat_xfs_bstat does not have forkoff

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: compat_xfs_bstat does not have forkoff
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 29 Sep 2014 03:43:18 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1411954886-12200-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1411954886-12200-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Mon, Sep 29, 2014 at 11:41:26AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> struct compat_xfs_bstat is missing the di_forkoff field and so does
> not fully translate the structure correctly. Fix it.
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_ioctl32.c | 2 ++
>  fs/xfs/xfs_ioctl32.h | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Any chance to get an xfstests test that verifies the forkoff value?
Even if it would only reproduce this bug when running 32-bit userspace
on a 64-bit kernel it would be useful I think.

<Prev in Thread] Current Thread [Next in Thread>