xfs
[Top] [All Lists]

Re: [PATCH 1/5] xfs: refactor xlog_recover_process_data()

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/5] xfs: refactor xlog_recover_process_data()
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 27 Sep 2014 09:22:01 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140926114238.GA16576@xxxxxxxxxxxxx>
References: <1411697952-24741-1-git-send-email-david@xxxxxxxxxxxxx> <1411697952-24741-2-git-send-email-david@xxxxxxxxxxxxx> <20140926114238.GA16576@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Sep 26, 2014 at 04:42:38AM -0700, Christoph Hellwig wrote:
> On Fri, Sep 26, 2014 at 12:19:08PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Clean up xlog_recover_process_data() structure in preparation for
> > fixing the allocation and freeing context of the transaction being
> > recovered.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Looks good.  The only behavior change I could spot was that we now
> validate the length of an ophdr even when starting a new transaction,
> which seems sensible.
> 
> Nipick: maybe the lp argument to xlog_recover_process_ophdr should
> be called end to make it more obvious?

Yes, I had that thought too. I'll change it.

> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Thanks!

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>