| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/3] xfs: remove bitfield based superblock updates |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Sat, 27 Sep 2014 09:02:35 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140926100027.GG10692@xxxxxxxxxxxxx> |
| References: | <1411647632-28240-1-git-send-email-david@xxxxxxxxxxxxx> <1411647632-28240-3-git-send-email-david@xxxxxxxxxxxxx> <20140926100027.GG10692@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, Sep 26, 2014 at 03:00:27AM -0700, Christoph Hellwig wrote:
> > + to->sb_uquotino = cpu_to_be64(from->sb_uquotino);
> > + if (xfs_sb_version_has_pquotino(from)) {
> > + to->sb_qflags = be16_to_cpu(from->sb_qflags);
> > + to->sb_gquotino = cpu_to_be64(from->sb_gquotino);
> > + to->sb_pquotino = cpu_to_be64(from->sb_pquotino);
> > + return;
> > + }
>
> sparse complains that the be16_to_cpu should be a cpu_to_be16 for
> sb_qflags..
Good catch. Fixed.
--
Dave Chinner
david@xxxxxxxxxxxxx
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/3] xfs: remove bitfield based superblock updates, Dave Chinner |
|---|---|
| Next by Date: | [PATCH 10/11 v2] xfs: check xfs_buf_read_uncached returns correctly, Dave Chinner |
| Previous by Thread: | Re: [PATCH 2/3] xfs: remove bitfield based superblock updates, Christoph Hellwig |
| Next by Thread: | [PATCH 3/3] xfs: consolidate superblock logging functions, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |