| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/5] xfs: refactor xlog_recover_process_data() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 26 Sep 2014 04:42:38 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1411697952-24741-2-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1411697952-24741-1-git-send-email-david@xxxxxxxxxxxxx> <1411697952-24741-2-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
On Fri, Sep 26, 2014 at 12:19:08PM +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Clean up xlog_recover_process_data() structure in preparation for > fixing the allocation and freeing context of the transaction being > recovered. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Looks good. The only behavior change I could spot was that we now validate the length of an ophdr even when starting a new transaction, which seems sensible. Nipick: maybe the lp argument to xlog_recover_process_ophdr should be called end to make it more obvious? Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 01/11] xfs: force the log before shutting down, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 2/5] xfs: recovery of XLOG_UNMOUNT_TRANS leaks memory, Christoph Hellwig |
| Previous by Thread: | [PATCH 1/5] xfs: refactor xlog_recover_process_data(), Dave Chinner |
| Next by Thread: | Re: [PATCH 1/5] xfs: refactor xlog_recover_process_data(), Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |