Re: [PATCH 11/11] xfs: simplify xfs_zero_remaining

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 11/11] xfs: simplify xfs_zero_remaining_bytes
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Fri, 26 Sep 2014 03:22:06 -0700
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1411648461-29003-12-git-send-email-david@xxxxxxxxxxxxx>
References:	<1411648461-29003-1-git-send-email-david@xxxxxxxxxxxxx> <1411648461-29003-12-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Thu, Sep 25, 2014 at 10:34:21PM +1000, Dave Chinner wrote:
> From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> 
> xfs_zero_remaining_bytes() open codes a log of buffer manupulations
> to do a read forllowed by a write. It can simply be replaced by an
> uncached read followed by a xfs_bwrite() call.
> 
> [Christoph, can I get your sign-off for this?]

Sure,

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/11 v2] xfs: clean up xfs_buf io interfaces, Dave Chinner [PATCH 02/11] xfs: Don't use xfs_buf_iowait in the delwri buffer code, Dave Chinner Re: [PATCH 02/11] xfs: Don't use xfs_buf_iowait in the delwri buffer code, Christoph Hellwig [PATCH 01/11] xfs: force the log before shutting down, Dave Chinner Re: [PATCH 01/11] xfs: force the log before shutting down, Christoph Hellwig [PATCH 03/11] xfs: synchronous buffer IO needs a reference, Dave Chinner Re: [PATCH 03/11] xfs: synchronous buffer IO needs a reference, Christoph Hellwig [PATCH 06/11] xfs: kill xfs_bdstrat_cb, Dave Chinner [PATCH 11/11] xfs: simplify xfs_zero_remaining_bytes, Dave Chinner Re: [PATCH 11/11] xfs: simplify xfs_zero_remaining_bytes, Christoph Hellwig <= Re: [PATCH 11/11] xfs: simplify xfs_zero_remaining_bytes, Brian Foster [PATCH 08/11] xfs: kill xfs_bioerror_relse, Dave Chinner Re: [PATCH 08/11] xfs: kill xfs_bioerror_relse, Christoph Hellwig Re: [PATCH 08/11] xfs: kill xfs_bioerror_relse, Brian Foster [PATCH 05/11] xfs: rework xfs_buf_bio_endio error handling, Dave Chinner Re: [PATCH 05/11] xfs: rework xfs_buf_bio_endio error handling, Christoph Hellwig [PATCH 07/11] xfs: xfs_bioerror can die., Dave Chinner Re: [PATCH 07/11] xfs: xfs_bioerror can die., Christoph Hellwig [PATCH 04/11] xfs: xfs_buf_ioend and xfs_buf_iodone_work duplicate functionality, Dave Chinner Re: [PATCH 04/11] xfs: xfs_buf_ioend and xfs_buf_iodone_work duplicate functionality, Christoph Hellwig

Previous by Date:	Re: [PATCH 10/11] xfs: check xfs_buf_read_uncached returns correctly, Christoph Hellwig
Next by Date:	Re: [PATCH 01/11] xfs: force the log before shutting down, Christoph Hellwig
Previous by Thread:	[PATCH 11/11] xfs: simplify xfs_zero_remaining_bytes, Dave Chinner
Next by Thread:	Re: [PATCH 11/11] xfs: simplify xfs_zero_remaining_bytes, Brian Foster
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 11/11] xfs: simplify xfs_zero_remaining_bytes