xfs
[Top] [All Lists]

Re: [PATCH 2/3] xfs: remove bitfield based superblock updates

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/3] xfs: remove bitfield based superblock updates
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 26 Sep 2014 03:00:27 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1411647632-28240-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1411647632-28240-1-git-send-email-david@xxxxxxxxxxxxx> <1411647632-28240-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
> +     to->sb_uquotino = cpu_to_be64(from->sb_uquotino);
> +     if (xfs_sb_version_has_pquotino(from)) {
> +             to->sb_qflags = be16_to_cpu(from->sb_qflags);
> +             to->sb_gquotino = cpu_to_be64(from->sb_gquotino);
> +             to->sb_pquotino = cpu_to_be64(from->sb_pquotino);
> +             return;
> +     }

sparse complains that the be16_to_cpu should be a cpu_to_be16 for
sb_qflags..

<Prev in Thread] Current Thread [Next in Thread>