xfs
[Top] [All Lists]

Re: [PATCH 4/4] xfs: annotate user variables passed as void

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/4] xfs: annotate user variables passed as void
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 26 Sep 2014 02:59:27 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1411601863-19594-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1411601863-19594-1-git-send-email-david@xxxxxxxxxxxxx> <1411601863-19594-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Thu, Sep 25, 2014 at 09:37:43AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Some argument callbacks can contain user buffers, and sparse warns
> about passing them as void pointers. Cast appropriately to remove
> the sparse warnings.

Looks okay.  I don't really like the games we're playing there, but this
isn't the time to fix them up..

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>