xfs
[Top] [All Lists]

Re: [PATCH 1/4] xfs: fix use of agi_newino in finobt lookup

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/4] xfs: fix use of agi_newino in finobt lookup
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 26 Sep 2014 02:47:48 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1411601863-19594-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1411601863-19594-1-git-send-email-david@xxxxxxxxxxxxx> <1411601863-19594-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Thu, Sep 25, 2014 at 09:37:40AM +1000, Dave Chinner wrote:
> Sparse warns that we are passing the big-endian valueo f agi_newino
> to the initial btree lookup function when trying to find a new
> inode. This is wrong - we need to pass the host order value, not the
> disk order value. This will adversely affect the next inode
> allocated, but given that the free inode btree is usually much
> smaller than the allocated inode btree it is much less likely to be
> a performance issue if we start the search in the wrong place.

Looks good.  I'm rather surprised this wasn't noticed earlier.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>