| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/3] xfs: consider freeze levels in xfs_fs_writable() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 25 Sep 2014 09:17:56 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1411647632-28240-2-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1411647632-28240-1-git-send-email-david@xxxxxxxxxxxxx> <1411647632-28240-2-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
> index d36bdbc..9073895 100644 > --- a/fs/xfs/xfs_mount.c > +++ b/fs/xfs/xfs_mount.c > @@ -607,7 +607,7 @@ xfs_mount_reset_sbqflags( > * If the fs is readonly, let the incore superblock run > * with quotas off but don't flush the update out to disk > */ > - if (mp->m_flags & XFS_MOUNT_RDONLY) > + if (!xfs_fs_writable(mp, SB_UNFROZEN)) This adds a new caller of xfs_fs_writable, which isn't mentioned in the changelog. > + /* > + * We can be called during the fs freeze process, and we need to be > + * able to write the superblock in that case. > + */ > + if (!xfs_fs_writable(mp, SB_FREEZE_FS)) > return 0; And this already changes the checked freeze level, also not mentioned. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: beginners project: RENAME_EXCHANGE, Carlos Maiolino |
|---|---|
| Next by Date: | Re: [PATCH 02/11] xfs: Don't use xfs_buf_iowait in the delwri buffer code, Christoph Hellwig |
| Previous by Thread: | [PATCH 1/3] xfs: consider freeze levels in xfs_fs_writable(), Dave Chinner |
| Next by Thread: | Re: [PATCH 1/3] xfs: consider freeze levels in xfs_fs_writable(), Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |