[Top] [All Lists]

Re: [PATCH 4/4] Adds ioctl interface support for ext4 project

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/4] Adds ioctl interface support for ext4 project
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Thu, 25 Sep 2014 09:41:37 -0400
Cc: Jan Kara <jack@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, adilger@xxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, dmonakhov@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, Li Xi <pkuelelixi@xxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=CobGLaQb/5sKxp+PvK5q5pXF8otHo4Cqli5Eyp/lcVE=; b=kqYqxJmo5uHKwjf19WZ7CANMkhe6VOzK1+Q+tAsAc9vIZAyMD3w7VpteejyskTWJyuiEC2JN5fOkK4j6UGmFi8jYxv5APVGvQBE6hOra7zkqOOvD3F4oBAufvC1pDArwpaY/fYD6Aq369Fm1nZy1BlctRqD3eklzAx/sGC+mGLQ=;
In-reply-to: <20140925075912.GG4758@dastard>
References: <1411567470-31799-1-git-send-email-lixi@xxxxxxx> <1411567470-31799-5-git-send-email-lixi@xxxxxxx> <20140924162507.GC27000@xxxxxxxxxxxxx> <20140924162634.GA16886@xxxxxxxxxxxxx> <20140924170105.GE27000@xxxxxxxxxxxxx> <20140925075912.GG4758@dastard>
User-agent: Mutt/1.5.23 (2014-03-12)
On Thu, Sep 25, 2014 at 05:59:12PM +1000, Dave Chinner wrote:
> > Also I'm afraid we may quickly run out of
> > 32 available flags in xflags so we'd need to extend that. But all this
> > seems to be doable.
> The struct fsxattr was designed to be extensible - it has unused
> padding and enough space in the flags field to allow us to
> conditionally use that padding....

I agree that it would be useful for ext4 to support as much of the
XFS_IOC_GETXATTR/XFS_IOC_SETATTR as would make sense for ext4, and to
use that to set/get the project ID.  (And that we should probably do
that as a separate set of patches that we could potentially go into
ext4 ahead of the project quota while it is undergoing testing and

A few questions of Dave and other XFS folks:

1) If we only implement a partial set of the flags or other
functionality, are there going to be tools that get confused?  i.e.,
are there any userspace programs that will test for whether the ioctl
is supported, and then assume that some minimal set of functionality
must be implemented?

2) Unless I'm missing something, there is nothing that enforces that
fsx_pad must be zero.  I assume that means that the only way you can
expand use of fields into that space is via a flag bit being consumed?


                                                - Ted

<Prev in Thread] Current Thread [Next in Thread>