xfs
[Top] [All Lists]

Re: [PATCH] libxfs: use structure initializers for cache_operations

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] libxfs: use structure initializers for cache_operations
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Mon, 22 Sep 2014 09:21:07 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <541C95B1.9020807@xxxxxxxxxxx>
References: <541C95B1.9020807@xxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Sep 19, 2014 at 03:44:33PM -0500, Eric Sandeen wrote:
> This makes it a lot easier for cscope etc.
> 
> Surely all modern compilers can cope?
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---

Seems reasonable to me.

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

> 
> diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
> index 9ee89d3..80de6fa 100644
> --- a/libxfs/rdwr.c
> +++ b/libxfs/rdwr.c
> @@ -1088,12 +1088,12 @@ libxfs_bcache_overflowed(void)
>  }
>  
>  struct cache_operations libxfs_bcache_operations = {
> -     /* .hash */     libxfs_bhash,
> -     /* .alloc */    libxfs_balloc,
> -     /* .flush */    libxfs_bflush,
> -     /* .relse */    libxfs_brelse,
> -     /* .compare */  libxfs_bcompare,
> -     /* .bulkrelse */libxfs_bulkrelse
> +     .hash           = libxfs_bhash,
> +     .alloc          = libxfs_balloc,
> +     .flush          = libxfs_bflush,
> +     .relse          = libxfs_brelse,
> +     .compare        = libxfs_bcompare,
> +     .bulkrelse      = libxfs_bulkrelse
>  };
>  
>  
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>