xfs
[Top] [All Lists]

Re: [PATCH] xfstests: remove check_scratch_fs in btrfs/012

To: Liu Bo <bo.li.liu@xxxxxxxxxx>, <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: remove check_scratch_fs in btrfs/012
From: Josef Bacik <jbacik@xxxxxx>
Date: Fri, 19 Sep 2014 11:02:38 -0400
Cc: linux-btrfs <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=message-id : date : from : mime-version : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=+GiEpT3TmwYoX5PR8OuC34466MeevyUVg04YR69oOFs=; b=KQRm402J7DDcuw/eYwsnlZVvTfu9WVfLtmT+Kh0+x5nDQPRAuDMbrKZVPOpwKqO663Wo 5nCBSdnAV1xeX+UqLOnYVXeZVAK7AF7Mma0LiWrXv8gf72KhQEdognoqT9zf7xzcBXOX Bx1ojHtTlO5mZxknm95jSSj6N1eDt7Eihuo=
In-reply-to: <1409714759-9805-1-git-send-email-bo.li.liu@xxxxxxxxxx>
References: <1409714759-9805-1-git-send-email-bo.li.liu@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0
On 09/02/2014 11:25 PM, Liu Bo wrote:
From: Liu Bo <liub.liubo@xxxxxxxxx>

btrfs/012 is a case to verify btrfs-convert feature, it converts an ext4 to
btrfs firstly and do something, then rolls back to ext4.

So at last we have a ext4 on the scratch device, but setting _require_scratch
will force a btrfsck on a ext4 fs because $FSTYP here is btrfs, and it ends up
with a failure report of _check_btrfs_filesystem.

Now that we have deliberately check the final ext4 fs in btrfs/012, just do not
set _require_scratch in this case.

Signed-off-by: Liu Bo <liub.liubo@xxxxxxxxx>

I sent a patch for this already, it's on the fs-tests list.  Thanks,

Josef

<Prev in Thread] Current Thread [Next in Thread>