xfs
[Top] [All Lists]

Re: [PATCH] xfstests: remove check_scratch_fs in btrfs/012

To: Liu Bo <bo.li.liu@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: remove check_scratch_fs in btrfs/012
From: Eryu Guan <guaneryu@xxxxxxxxx>
Date: Fri, 19 Sep 2014 14:37:48 +0800
Cc: xfs@xxxxxxxxxxx, linux-btrfs <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Ft1dbo18sjKT/yu4sO+QtQjY3u+PIsDSP/DttCoiX6I=; b=SbRYwwRsQcmz3AdjE/hJ00dm+tVCNkdin5CGayBBDft3dYgqeaUrqVwEIa1+VXQXXR HQTCDIM8vGwjgl2Wuf/Hd1exO+DglzxT7IfORcRpQSLXDKE/md5OfvLfyMQ8aIS8vxrj bCUKYY8j1zEwKNI1NUb9rb2t05L2Xj3k+w5WqY++szTuWA/mn6EvkkZofuvj14NWz4vv lyVZVSqgmHE9S+G2H02OzGKrS9hODj8txPWhHwgON3ZysHoF01XzhpSPcCCBWqISskTA 5uMwnmlCk1REPCyh2yxFD4dGxpIlZuLUtH4qA/YTzWXQlCIajlY3Phr/xf5sBw+vZi8j m/OQ==
In-reply-to: <1409714759-9805-1-git-send-email-bo.li.liu@xxxxxxxxxx>
References: <1409714759-9805-1-git-send-email-bo.li.liu@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Wed, Sep 03, 2014 at 11:25:59AM +0800, Liu Bo wrote:
> From: Liu Bo <liub.liubo@xxxxxxxxx>
> 
> btrfs/012 is a case to verify btrfs-convert feature, it converts an ext4 to
> btrfs firstly and do something, then rolls back to ext4.
> 
> So at last we have a ext4 on the scratch device, but setting _require_scratch
> will force a btrfsck on a ext4 fs because $FSTYP here is btrfs, and it ends up
> with a failure report of _check_btrfs_filesystem.
> 
> Now that we have deliberately check the final ext4 fs in btrfs/012, just do 
> not
> set _require_scratch in this case.
> 
> Signed-off-by: Liu Bo <liub.liubo@xxxxxxxxx>
> ---
>  tests/btrfs/012 | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/btrfs/012 b/tests/btrfs/012
> index f7e5da5..12f6462 100755
> --- a/tests/btrfs/012
> +++ b/tests/btrfs/012
> @@ -52,7 +52,6 @@ _cleanup()
>  # Modify as appropriate.
>  _supported_fs btrfs
>  _supported_os Linux
> -_require_scratch

The test still requires a scratch device, so we cannot simply remove
this line. Now we can use _require_scratch_nocheck helper, and it
works fine based on my test.

Thanks,
Eryu

>  
>  BTRFS_CONVERT_PROG="`set_prog_path btrfs-convert`"
>  MKFS_EXT4_PROG="`set_prog_path mkfs.ext4`"
> -- 
> 1.8.1.4
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>