xfs
[Top] [All Lists]

Re: [PATCH v2] xfsrestore: use utimensat() to provide atime/mtime with n

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v2] xfsrestore: use utimensat() to provide atime/mtime with ns resolution
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 13 Sep 2014 12:47:13 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1409866939-1480-1-git-send-email-bfoster@xxxxxxxxxx>
References: <1409866939-1480-1-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Thu, Sep 04, 2014 at 05:42:19PM -0400, Brian Foster wrote:
> xfsdump encodes and stores the full atime and mtime for each file with
> nanosecond resolution. xfsrestore uses utime() to set the times of each
> file that is restored. The latter supports resolution of 1 second, thus
> sub-second timestamp data is lost on restore.
> 
> Add the associated configure checks for and use utimensat() when
> available to restore timestamps with nanosecond resolution. Create a new
> helper to facilitate conditional support for utimensat().
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Looks good to me,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>