[Top] [All Lists]

Re: [PATCH V3] xfs_io: add mremap command

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V3] xfs_io: add mremap command
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 13 Sep 2014 12:45:59 -0700
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <54132553.9090202@xxxxxxxxxxx>
References: <54111610.4080604@xxxxxxxxxx> <54132553.9090202@xxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Sep 12, 2014 at 11:54:43AM -0500, Eric Sandeen wrote:
> This adds a simple mremap command to xfs_io.
> It does not take a start address; it uses the existing
> start address, so the sized passed will be the new total
> size of the mapping.
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good to me, but I'd feel much more comfortable about merging it
if we had an xfstests test case that actually exercises it.

<Prev in Thread] Current Thread [Next in Thread>