xfs
[Top] [All Lists]

Re: [PATCH v2 0/5] clean up collapse range and handle post-eof delalloc

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v2 0/5] clean up collapse range and handle post-eof delalloc
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 11 Sep 2014 14:42:43 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1410355231-50495-1-git-send-email-bfoster@xxxxxxxxxx>
References: <1410355231-50495-1-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Sep 10, 2014 at 09:20:26AM -0400, Brian Foster wrote:
> Hi all,
> 
> Here's v2 of the collapse clean up. We refactor a bit more via the
> insertion of patch 3, otherwise it's similar to v1. This will see some
> continued testing, but it survived ~500m fsx operations overnight.
> 
> Brian

I'm not sure about the invalidation patch now. On a 1k block size
filesystem, generic/127 fails with:

    +ltp/fsx -q -l 262144 -o 65536 -S 191110531 -N 100000 -R -W fsx_std_nommap
    +collapse range: 1000 to 3000
    +do_collapse_range: fallocate: Device or resource busy

which indicates we had an invalidation failure. This is probably
exposing some other bug, but I haven't had time to look into it yet
so I don't know.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>